Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gate): not accepting null value for alternative address #934

Merged
merged 1 commit into from
May 22, 2024
Merged

fix(gate): not accepting null value for alternative address #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...i/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/response/BusinessPartnerDto.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,6 @@ data class AddressRepresentationInputDto(
override val name: String? = null,
override val addressType: AddressType? = null,
override val physicalPostalAddress: PhysicalPostalAddressDto = PhysicalPostalAddressDto(),
override val alternativePostalAddress: AlternativePostalAddressDto = AlternativePostalAddressDto(),
override val alternativePostalAddress: AlternativePostalAddressDto? = null,
override val states: Collection<BusinessPartnerStateDto> = emptyList(),
) : IBaseAddressRepresentation
2 changes: 1 addition & 1 deletion ...main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/response/BusinessPartnerOutputDto.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ data class AddressComponentOutputDto(
override val name: String? = null,
override val addressType: AddressType?,
override val physicalPostalAddress: PhysicalPostalAddressDto = PhysicalPostalAddressDto(),
override val alternativePostalAddress: AlternativePostalAddressDto = AlternativePostalAddressDto(),
override val alternativePostalAddress: AlternativePostalAddressDto? = null,
val confidenceCriteria: ConfidenceCriteriaDto,
override val states: Collection<BusinessPartnerStateDto> = emptyList()
) : IBaseAddressRepresentation
2 changes: 1 addition & 1 deletion bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/service/BusinessPartnerMappings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class BusinessPartnerMappings {
name = entity.addressName,
addressType = entity.postalAddress.addressType,
physicalPostalAddress = entity.postalAddress.physicalPostalAddress?.toPhysicalPostalAddress() ?: PhysicalPostalAddressDto(),
alternativePostalAddress = entity.postalAddress.alternativePostalAddress?.toAlternativePostalAddressDto() ?: AlternativePostalAddressDto(),
alternativePostalAddress = entity.postalAddress.alternativePostalAddress?.toAlternativePostalAddressDto(),
states = toStateDtos(entity.states, BusinessPartnerType.ADDRESS)
)
}
Expand Down