-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TRG-7): update licensing and legal docs #974
chore(TRG-7): update licensing and legal docs #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still an old link to the CC-BY-4.0 license in the NOTICE file. This would need to be changed to the license file in the bpdm-pool resources regions folder. Other than that, looks good to me.
bf2e64d
to
79b3697
Compare
@nicoprow, I have removed old license file from bpdm-pool resources and also, updated correct link to CC-BY-4.0 license in the NOTICE file. I kept only one LICENSE_non-code file. Hope it is ok. |
@SujitMBRDI sorry, I was not clear on that part. That license file must stay as it is part of third party content that we use in our project. We have to keep the license at the same place as the third party file we use in our project. The NOTICE for the thirs party content still needs to point to the license file in the resources and this license file can't be deleted. In doubt, we need to consult in Eclipse but I'm pretty sure that's how we need to do it |
chore(TRG-7): removed old link to license chore(TRG-7): added licence text file for third party content.
a69fbb5
to
6d05813
Compare
@nicoprow, I have adapted changes in the way suggested. Hi @AngelikaWittek, just wanted to confirm about correctness of the declaring third party content and mandatory change in licensing in our repository.
|
Hi, if you want to reference a license (CC-BY-4.0), then link to the source: Angelika |
Description
Why
#956
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: