Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TRG-7): update licensing and legal docs #974

Merged

Conversation

SujitMBRDI
Copy link
Contributor

@SujitMBRDI SujitMBRDI commented Jun 24, 2024

Description

  • Updated licensing and legal docs

Why

#956

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI requested a review from nicoprow June 24, 2024 06:27
@SujitMBRDI SujitMBRDI self-assigned this Jun 24, 2024
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an old link to the CC-BY-4.0 license in the NOTICE file. This would need to be changed to the license file in the bpdm-pool resources regions folder. Other than that, looks good to me.

@nicoprow nicoprow requested a review from SebastianBezold June 25, 2024 02:37
@SujitMBRDI SujitMBRDI force-pushed the feat/update_license_info branch from bf2e64d to 79b3697 Compare June 25, 2024 05:31
@SujitMBRDI
Copy link
Contributor Author

There is still an old link to the CC-BY-4.0 license in the NOTICE file. This would need to be changed to the license file in the bpdm-pool resources regions folder. Other than that, looks good to me.

@nicoprow, I have removed old license file from bpdm-pool resources and also, updated correct link to CC-BY-4.0 license in the NOTICE file. I kept only one LICENSE_non-code file. Hope it is ok.

@SujitMBRDI SujitMBRDI requested a review from nicoprow June 25, 2024 05:33
@nicoprow
Copy link
Contributor

There is still an old link to the CC-BY-4.0 license in the NOTICE file. This would need to be changed to the license file in the bpdm-pool resources regions folder. Other than that, looks good to me.

@nicoprow, I have removed old license file from bpdm-pool resources and also, updated correct link to CC-BY-4.0 license in the NOTICE file. I kept only one LICENSE_non-code file. Hope it is ok.

@SujitMBRDI sorry, I was not clear on that part. That license file must stay as it is part of third party content that we use in our project. We have to keep the license at the same place as the third party file we use in our project. The NOTICE for the thirs party content still needs to point to the license file in the resources and this license file can't be deleted.

In doubt, we need to consult in Eclipse but I'm pretty sure that's how we need to do it

chore(TRG-7): removed old link to license

chore(TRG-7): added licence text file for third party content.
@SujitMBRDI SujitMBRDI force-pushed the feat/update_license_info branch from a69fbb5 to 6d05813 Compare June 25, 2024 09:47
@SujitMBRDI
Copy link
Contributor Author

There is still an old link to the CC-BY-4.0 license in the NOTICE file. This would need to be changed to the license file in the bpdm-pool resources regions folder. Other than that, looks good to me.

@nicoprow, I have removed old license file from bpdm-pool resources and also, updated correct link to CC-BY-4.0 license in the NOTICE file. I kept only one LICENSE_non-code file. Hope it is ok.

@SujitMBRDI sorry, I was not clear on that part. That license file must stay as it is part of third party content that we use in our project. We have to keep the license at the same place as the third party file we use in our project. The NOTICE for the thirs party content still needs to point to the license file in the resources and this license file can't be deleted.

In doubt, we need to consult in Eclipse but I'm pretty sure that's how we need to do it

@nicoprow, I have adapted changes in the way suggested.

Hi @AngelikaWittek, just wanted to confirm about correctness of the declaring third party content and mandatory change in licensing in our repository.
In our notice file we have mentioned third party content as below, where we provided absolute path for third party license file.

## Third-party Content

This project leverages the following third party content.

### Dependencies

See [DEPENDENCIES](DEPENDENCIES) file.

### Administrative Areas Level 1

- Description: CSV file content for ISO-3166-2
- SPDX-License-Identifier: [CC-BY-4.0](bpdm-pool/src/main/resources/regions/LICENSE.TXT)
- File Location: [IP2LOCATION-ISO3166-2.CSV](bpdm-pool/src/main/resources/regions/IP2LOCATION-ISO3166-2.CSV)
- Source URL: https://www.ip2location.com

@nicoprow nicoprow merged commit 1172a94 into eclipse-tractusx:main Jul 3, 2024
10 checks passed
@AngelikaWittek
Copy link

AngelikaWittek commented Jul 3, 2024

Hi, if you want to reference a license (CC-BY-4.0), then link to the source:
CC-BY-4.0.
See also TRG 7.08.
And please review in your team. I removed myself from the reviewer list.

Angelika

@AngelikaWittek AngelikaWittek removed their request for review July 3, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants