Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gate): Starting Golden Record Process Without Changes #988

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jul 5, 2024

Description

When upserting business partner input to the BPDM Gate that matches the existing business partner input, the Gate would still send the unchanged input data unnecessarily to the Golden Record Process.

This pull request fixes this behaviour. Now the Gate only sends data to the Golden Record Process if it has been changed.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

… even when they have no changes

- now business partner service only sets the sharing state to ready or initial when the data really has been changed
@nicoprow nicoprow added the bug Something isn't working label Jul 5, 2024
@nicoprow nicoprow requested a review from SujitMBRDI July 5, 2024 07:01
@nicoprow nicoprow marked this pull request as ready for review July 5, 2024 07:54
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nicoprow nicoprow merged commit 1f15ba8 into main Jul 5, 2024
16 checks passed
@nicoprow nicoprow deleted the fix/gate/input-ready branch July 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants