fix(gate): Assigning Wrong Task-Ids #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… orchestrator - now made sure sharing states are associated with the tasks in the order of the task create requests
SujitMBRDI
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the Gate sends business partner data to the Orchestrator, it can happen that it saves the wrong golden record task-ID to the wrong sharing state, by this mixing up the desired results in the output stage.
This pull request fixes the behaviour making sure that the task-Ids are assigned to the correct sharing states as long as the Orchestrator returns the tasks in the order in which the requests have been received.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: