New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge from CatenaX fork #383

Merged

ds-jhartmann merged 44 commits into eclipse-tractusx:main from catenax-ng:main

Jan 23, 2024

Contributor

ds-psosnowski commented Jan 23, 2024 •

edited by ds-jhartmann

Loading

Description

Updated license header to "Copyright (c) 2021,2024 Contributors to the Eclipse Foundation"
Changed lookupGlobalAssetIds to lookupShellsByBPN, which provides full object.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files

ds-jhartmann and others added 30 commits

December 20, 2023 13:47


          chore(docs):[#223] Create concept for transfer to PCWM

ee0f03b


          chore(docs):[#223] Updates after review

762a250


          chore(#322):[#322] prepare template for concept

7f14aa4


          chore(concept):[#322] add initial concept

5d46bc9


          chore(concept):[#322] add requirements and initial idea how to store …

0a21ff3

…contractAgreementId


          chore(concept):[#322] add edc management api endpoints and abstract d…

adf5ef4

…efinition


          chore(concept):[#322] alignment meeting with trace-x follow ups

a044034


          chore(concept):[#322] add sequence diagram for receiving EDR token

d23b925


          Merge pull request #723 from eclipse-tractusx/main

fdb3863

sync with upstream


          chore(concept):[#322] adapted toc

c73097d


          chore(concept):[#322] adapted toc of template

50d115b


          chore(concept):[#322] adjusted fontfamiliy because of readabiliy reasons

4d9262d


          chore(concept):[#322] adjusted the concept first corrections

71487e8


          chore(concept):[#322] typo and corrections filled missing summary

edf9163


          feat(decentral-client-library):412-tracex changed lookupGlobalAssetId…

d479140

…s to lookupShellsByBPN. Response now delivery the full object instead of the globalAssetId string as list.


          feat(decentral-client-library):412-tracex fixed typo.

4ec170c


          feat(decentral-client-library):412-tracex add changelog entry.

5b9e1a2


          chore(workflows): Skip checkstyle and pmd for sonar scan

42fdc76


          chore(workflows): Revert secret placeholder change

ecb6ab0


          Merge pull request #726 from catenax-ng/chore/improve-sonar-scan

0d02b99

chore(workflows): Skip checkstyle and PMD for sonar scan


          chore(docs):[#223] Add review suggestions

d179f13

Co-authored-by: ds-mkanal <[email protected]>


          Merge branch 'main' into feature/412-tracex-adapt-registry-lookup

ee9baea


          Merge pull request #701 from catenax-ng/chore/#223-concept-for-pcwm

d832f04

chore(docs):[#223] Create concept for transfer to PCWM


          chore(concept):[#322] Update docs/concept/#322-Provisioning-of-contra…

…ct-definiton-for-assets/#322-Provisioning-of-contract-definiton-for-assets.md

Co-authored-by: Jaro Hartmann <[email protected]>


          chore(concept):[#322] Update docs/concept/#322-Provisioning-of-contra…

cb510ed

…ct-definiton-for-assets/#322-Provisioning-of-contract-definiton-for-assets.md

Co-authored-by: Jaro Hartmann <[email protected]>


          chore(concept):[#322] Update docs/concept/#322-Provisioning-of-contra…

9a5f848

…ct-definiton-for-assets/#322-Provisioning-of-contract-definiton-for-assets.md

Co-authored-by: Jaro Hartmann <[email protected]>


          chore(concept):[#322] Update docs/concept/#322-Provisioning-of-contra…

4803eea

…ct-definiton-for-assets/#322-Provisioning-of-contract-definiton-for-assets.md

Co-authored-by: Jaro Hartmann <[email protected]>


          chore(concept):[#322] Update docs/concept/#322-Provisioning-of-contra…

747ea9e

…ct-definiton-for-assets/#322-Provisioning-of-contract-definiton-for-assets.md

Co-authored-by: Jaro Hartmann <[email protected]>


          chore(concept):[#322] add title and rename files

707d1f3

 typo and corrections filled missing summary


          chore(concept):[#322] remove html links in toc

d834f60

mkanal and others added 14 commits

January 19, 2024 16:30


          chore(concept):[#322] add changelog entry

0fda2a6


          fix(concept):[#322] fix review comments

47cfa23


          fix(concept):[#322] remove <> from status add sequence diagram for ca…

54cdfc8

…se 3


          chore(irs-build): Remove JaCoCo package-level coverage check. This is…

a5b40e1

… already done by Sonar


          chore(concept):[#322] Formatting

a95adb0


          chore(concept):[#322] Formatting

e2b69ae


          Merge pull request #724 from catenax-ng/chore/#322-Provisioning-of-co…

0746ce4

…ntract-negotiation-and-contract-assessment-for-assets

Chore/#322 provisioning of contract negotiation and contract assessment for assets


          chore(concept):[#322] correct tombstone using UsagePolicyValidation

ebff564


          Merge pull request #730 from catenax-ng/chore/#322-Provisioning-of-co…

cab0c48

…ntract-aggreement-id

chore(concept):[#322] correct tombstone using UsagePolicyValidation


          chore(foss):[#349] Also update the detailed copyright section in the …

d51258c

…license headers

This change was neither described in the acceptance criteria nor did the TRG 7.02  require it, but this additional change was requested by the PO in the iteration session.


          Merge pull request #728 from catenax-ng/chore/code-coverage

22f1c92

chore(irs-build): Remove JaCoCo package-level coverage check. This is…


          Merge branch 'main' into feature/412-tracex-adapt-registry-lookup

34e2713


          Merge pull request #731 from catenax-ng/chore/349-update-license-headers

016b65a

chore(foss):[#349] Also update the detailed copyright section


          Merge pull request #725 from catenax-ng/feature/412-tracex-adapt-regi…

e7b757a

…stry-lookup

feat(decentral-client-library):412-tracex changed lookupGlobalAssetId request

github-advanced-security bot found potential problems

View reviewed changes

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check warning

Code scanning / KICS

Using Unrecommended Namespace Warning

metadata.namespace is undefined or null

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Image Without Digest Note

metadata.name={kics-helm-irs-helm}.spec.template.spec.containers.name={irs-helm}.image does not include an image digest

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Missing AppArmor Profile Note

metadata.name={kics-helm-irs-helm}.spec.template.metadata.annotations does not specify an AppArmor profile for container {irs-helm}

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Pod or Container Without LimitRange Note

metadata.name={kics-helm-irs-helm} does not have a 'LimitRange' policy associated

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Pod or Container Without ResourceQuota Note

metadata.name={kics-helm-irs-helm} does not have a 'ResourceQuota' policy associated

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Secrets As Environment Variables Note

'spec.template.spec.containers.name={irs-helm}.env.name={MINIO_SECRET_KEY}.valueFrom.secretKeyRef' is defined

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Secrets As Environment Variables Note

'spec.template.spec.containers.name={irs-helm}.env.name={OAUTH2_CLIENT_ID}.valueFrom.secretKeyRef' is defined

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Secrets As Environment Variables Note

'spec.template.spec.containers.name={irs-helm}.env.name={PORTAL_OAUTH2_CLIENT_SECRET}.valueFrom.secretKeyRef' is defined

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Secrets As Environment Variables Note

'spec.template.spec.containers.name={irs-helm}.env.name={PORTAL_OAUTH2_CLIENT_ID}.valueFrom.secretKeyRef' is defined

charts/irs-helm/templates/deployment.yaml

    
            @@ -1,7 +1,7 @@
          
              # Copyright (c) 2021,2022,2023

              # Copyright (c) 2022,2024

Check notice

Code scanning / KICS

Secrets As Environment Variables Note

'spec.template.spec.containers.name={irs-helm}.env.name={MINIO_ACCESS_KEY}.valueFrom.secretKeyRef' is defined

ds-jhartmann approved these changes

View reviewed changes

Contributor

ds-jhartmann left a comment

LGTM

ds-jhartmann merged commit 58a2ddc into eclipse-tractusx:main

17 of 19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet