feat(impl): [#528] Improvements Policy Store Input Validation #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation-Improve
in order to deduplicate common test code
dsmf
changed the title
6 tasks
…se it in PolicyStoreService reason: validation logic in one place (single responsibility)
…ing error response message
…ing error response message
…ting error response message
…alidation-Improve
ds-jhartmann
requested changes
May 13, 2024
...icy-store/src/main/java/org/eclipse/tractusx/irs/policystore/models/CreatePolicyRequest.java
Show resolved
Hide resolved
...icy-store/src/main/java/org/eclipse/tractusx/irs/policystore/models/UpdatePolicyRequest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/tractusx/irs/policystore/validators/PolicyIdListValidatorTest.java
Outdated
Show resolved
Hide resolved
...store/src/test/java/org/eclipse/tractusx/irs/policystore/validators/PolicyValidatorTest.java
Outdated
Show resolved
Hide resolved
...y-store/src/main/java/org/eclipse/tractusx/irs/policystore/validators/PolicyIdValidator.java
Outdated
Show resolved
Hide resolved
…alidation-Improve # Conflicts: # irs-edc-client/src/test/java/org/eclipse/tractusx/irs/edc/client/SubmodelFacadeWiremockTest.java # irs-policy-store/src/test/java/org/eclipse/tractusx/irs/policystore/persistence/PolicyPersistenceTest.java
…r characters New pattern "[a-zA-Z0-9\-_~.:]+" (safe path variable characters). Reason: Avoid problems with too strict validation.
ds-jhartmann
deleted the
feat/528-Policy-Store-API-Input-Validation-Improve
branch
ds-jhartmann
added a commit
to ds-jhartmann/item-relationship-service
that referenced
this pull request
Jun 13, 2024
…468-enable-full-library-release Feature/tri 1468 enable full library release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: