Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(impl): [#734] Handling for modification attempts on read-only de… #835

Conversation

dsmf
Copy link
Contributor

@dsmf dsmf commented Jul 19, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but missing Tests.
Please add some unit tests to cover your changes.

dsmf added 3 commits July 23, 2024 12:59
… on read-only default policies: tests, readability

- Add missing tests for trial to register, update or delete fallback policy
- Enhance code readability by relocating checks from the catch block to the beginning of relevant methods.
… on read-only default policies: add handleTrialToModifyFallbackPolicy to registerPolicy method
@dsmf dsmf requested a review from ds-jhartmann July 23, 2024 13:16
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit 3eeee6a into eclipse-tractusx:main Jul 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants