-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cucumber):[#226] Fix umbrella e2e test scenarios #856
Conversation
0eb660f
to
d25049c
Compare
Test Results16 tests - 20 1 ✅ - 26 0s ⏱️ - 16m 57s For more details on these failures, see this check. Results for commit 943f7ea. ± Comparison against base commit f0098f4. This pull request removes 36 and adds 16 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
CHANGELOG file was not updated! Make sure to include important changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
schedule: | ||
- cron: '0 2 * * 1-5' # At 02:00 on every day-of-week from Monday through Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no scheduled run anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Workflow is triggered on every push to main, I don't think it is necessary to run the Umbrella Cucumber Tests scheduled.
The Umbrella Environment is created from scratch every time, so nothing will change between the latest push to main and the scheduled execution
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixed umbrella cucumber tests.
All tests are green now https://reports.cucumber.io/reports/f6196d3c-c1be-4753-a391-f8dde430ffe4
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: