Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:cxar 921 agent plane qg4 #15

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Aug 22, 2023

WHAT

went over TRG 1-7 and adopted as many guidelines as possible

WHY

initial contribution was not completely aligned since it could not be tested under the catenax-ng fork.

FURTHER NOTES

Helm Test & Upgrade could not be done as the charts have been derived from tractusx-edc and require a running vault.

Closes #18
Largely Closes #17

…al jars, skill distribution warnings should show asset name, urlencoded parameters which have been parsed should be allowed and reencoded in delegation.
…ower-case content-length header which would commit/close the response body before being written.
@drcgjung drcgjung marked this pull request as ready for review August 22, 2023 14:12
@drcgjung
Copy link
Contributor Author

drcgjung commented Aug 22, 2023

@SebastianBezold the next PR which should render a repo TRG-compatible (up to the final release of the artifacts and deploying helm tests and updates - these are also not part of tractusx-edc actions. hence I could not find how to setup a local EDC deployment including a vault)

As with knowledge-agents, release will be done

  • maven/docker upon push to main or vx.x.x tag
  • helm upon push to main or release branch

The difference is caused in maven repo typically not allowing to simply "update" existing artifacts (unless they are SNAPSHOTS from main)

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SebastianBezold SebastianBezold merged commit 8d0305d into eclipse-tractusx:main Aug 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LICENSE missing for Helm Charts QG 4 checks Release 3.2
2 participants