Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #201 license issues #208

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

drcgjung
Copy link
Contributor

WHAT

added Terms of Use in CONTRIBUTING file
extended NOTICE file with a notice for the CC-BY-4.0 license
added the CC-BY-4.0 license to the root repository as default license for non-code artifacts
upped the version to prepare TX/CX 24.08 release.

WHY

Updates due to changes in TRG 7:

FURTHER NOTES

Closes #201

@drcgjung drcgjung added the enhancement New feature or request label Jun 14, 2024
@drcgjung drcgjung changed the title Fix/201 licenses fix: #201 license issues Jun 14, 2024
@drcgjung drcgjung requested a review from obalandi June 14, 2024 14:25
@SebastianBezold
Copy link
Contributor

Hi @drcgjung,

the licence and copyright changes look good to me.
I am unsure about the version change though.

  • Is it even necessary? Is your documentation released, or put in one of the released artifacts
  • If there is a version bump, wouldn't 1.13.0 the next one? Couldn't find a 1.13.x release yet

@drcgjung
Copy link
Contributor Author

Hi @drcgjung,

the licence and copyright changes look good to me. I am unsure about the version change though.

* Is it even necessary? Is your documentation released, or put in one of the released artifacts

* If there is a version bump, wouldn't `1.13.0` the next one? Couldn't find a `1.13.x` release yet

Necessary: to prepare the upcoming PI13/24.08 release (there will be a PR to adapt to TX EDC 0.7.2 in the coming days).

Wrt semantic versioning: We never count back "minor" and "build" because they are in fact incremental. Matter of style I would guess.

@SebastianBezold SebastianBezold merged commit c4cffde into eclipse-tractusx:main Jun 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Mandatory change in licensing and legal documentation
3 participants