-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:cxar-919 quality gates #21
feat:cxar-919 quality gates #21
Conversation
…mize reference in readme
@SebastianBezold I really appreciate your help, still struggling a little bit with the chart testing workflow. "A bit" was tremendously underestimated. Now the lint workflow also builds the docker images, pushes them to the local registry and tests them in the local cluster. Release mechanism would be as follows:
The difference is caused in maven repo typically not allowing to simply "update" existing artifacts (unless they are SNAPSHOTS from main) |
…ebug chart yaml
…elm. Remove KICS warnings (although the CPU limit > CPU requests was suggested by TRG
…gistry, using the correct ct command line
…de when dispatch is not run
…shot and vx.x.x tags
…residues so we cannot separate the steps
Hi @drcgjung, now worries, we will get that to work :)
In best case, the Info, that you are linking to is either included in the PR description itself, or a related GitHub issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @drcgjung could you have a look at the comments regarding the additional info for your used Docker base images and decide, if you want to include it in this PR, or open issues for future addition?
remoting/README.md
Outdated
|
||
Used base image | ||
|
||
[tomcat:9-jre11-temurin](https://hub.docker.com/_/tomcat/tags?page=1&name=9-jre11-temurin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for ontop/ontop
we need to provide more info about where to find the original source and so on
Thanks for the base image info @drcgjung 👍 |
WHAT
WHY
FURTHER NOTES
Largely Closes #5
Closes #20
Closes #19
Merge Hopefully Closes #18