Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maven) and fix(remoting): #28 and SAST-mitigations #29

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Aug 25, 2023

WHAT

Legal documents should be part of the distribution artifacts (here: jars).
Documentation markdown and images need correct legal notices.
Mitigate high and medium vulnerabilities indicated by SAST analysis in the remoting submodule.
Enable reasonable SAST on the provisioning module.
Align trivy and docker meta tags.

WHY

TRG 7.05
TRG 7.07
SAST Policy

FURTHER NOTES

The remoting agent is docker-embedded into an existing tomcat/spring-web environment.
The compile-time dependencies and the runtime dependencies differed a bit (e.g. snappy was correctly downloaded in the maven build, but in the maven deps it was still the "natural" one from the dependency tree).
This has now been resolved (and downloading in the maven build was restricted to the absolute minimum which is the rdf4j sdk).

Closes #28
Closes #30

@drcgjung
Copy link
Contributor Author

It was a flaw indeed.

@drcgjung drcgjung changed the title chore(maven): #28 add legal info as META-INF resources to the jar artifacts. chore(maven) and fix(remoting): #28 and SAST-mitigations Aug 26, 2023
@SebastianBezold
Copy link
Contributor

Hi @drcgjung,
I can see changes to the pom.xml, but no changes to the DEPENDENCIES file. Could you make sure the DEPENDENCIES are up-to-date, so we can see, if 3rd party IP checks are necessary?

@SebastianBezold SebastianBezold mentioned this pull request Aug 28, 2023
77 tasks
@SebastianBezold
Copy link
Contributor

Thx for updating the DEPENDENCIES @drcgjung 👍. Will merge the PR

@SebastianBezold SebastianBezold merged commit 362df0d into eclipse-tractusx:main Aug 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add legal notice for documentation Clarification: Legal info for distribution (TRG 7.05)
2 participants