-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(maven) and fix(remoting): #28 and SAST-mitigations #29
Merged
SebastianBezold
merged 9 commits into
eclipse-tractusx:main
from
catenax-ng:feature/CXAR-919-quality-gates
Aug 28, 2023
Merged
chore(maven) and fix(remoting): #28 and SAST-mitigations #29
SebastianBezold
merged 9 commits into
eclipse-tractusx:main
from
catenax-ng:feature/CXAR-919-quality-gates
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to the jar artifacts.
It was a flaw indeed. |
…NF resources to the jar artifacts.
…ing requests unsanitized. disable entity resolution in xml processing.
…ready present in the docker container..
drcgjung
changed the title
chore(maven): #28 add legal info as META-INF resources to the jar artifacts.
chore(maven) and fix(remoting): #28 and SAST-mitigations
Aug 26, 2023
Hi @drcgjung, |
Thx for updating the |
SebastianBezold
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Legal documents should be part of the distribution artifacts (here: jars).
Documentation markdown and images need correct legal notices.
Mitigate high and medium vulnerabilities indicated by SAST analysis in the remoting submodule.
Enable reasonable SAST on the provisioning module.
Align trivy and docker meta tags.
WHY
TRG 7.05
TRG 7.07
SAST Policy
FURTHER NOTES
The remoting agent is docker-embedded into an existing tomcat/spring-web environment.
The compile-time dependencies and the runtime dependencies differed a bit (e.g. snappy was correctly downloaded in the maven build, but in the maven deps it was still the "natural" one from the dependency tree).
This has now been resolved (and downloading in the maven build was restricted to the absolute minimum which is the rdf4j sdk).
Closes #28
Closes #30