-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs|fix|chore(provisioning-agent): SAST Flaws and CHANGELOG #31
docs|fix|chore(provisioning-agent): SAST Flaws and CHANGELOG #31
Conversation
…tity resolution disablement. Align SAST and docker runtime versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your docker file provisioning/src/main/docker/Dockerfile you change the permission to 755. I think just the ontop user needs executable permission. Maybe chmod 700 is sufficient enough.
I also added some security docs to your XMLProvider class - makes it easier to understand. |
For extra points - you could validate the XML to a schema. This is the best way to prevent XML injection attacks. |
Good point: |
…ypoint. more realistic postgres test.
WHAT
Addressed four issues from SAST (2XSLT External Entity Disablement, 2Discrepancy between unclean maven deps and clean docker runtime)
Already reference upcoming release in CHANGELOG
Include a cloud-based postgres test which reflects a valid deployment scenario (and its current pitfalls).
WHY
CHANGELOG should reflect release status (TRG)
Render SAST analysis green and close to 100%
include test settings from E2E tests.
FURTHER NOTES