fix: Provisioning Agent Ontology Configuration & JRW Compatibility with Dremio Drivers #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin0815bla
approved these changes
Feb 9, 2024
…ritical version. Document the manual postprocessing of spring-web-5 to remove the critical invoker package.
|
@carslen would you be so kind to "adopt" this PR ... it would be needed for getting SAST approval. |
|
@almadigabor it would be wonderful, if you could take over this PR ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This fix resolves two issues with the provisioning agent which appeared during the E2E Test 24.03 (shell script & JRE platform).
It also documents the version changes (on logback) and hardening efforts (on spring web) between the 1.10 and 1.11 lines.
Some github actions have been upgraded, too.
WHY
Due to an erroneous command line, the ontology configurations were not taken from the environment variables correctly for all endpoints but the last.
Furthermore, when working against a virtualizer, such as dremio, the jdbc drives included in the image need to be compatible with the JRE version (else their network stack could run into connection problems).
FURTHER NOTES
Dremio switched their driver model in a later/more current version from a proprietary to an open-source based generic one.
We should have a look at that for the 1.12.x line/24.05
Closes #81
Closes #82