-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Automated DAST scanning #89
feature: Automated DAST scanning #89
Conversation
retention day added
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Bearer Token | 5739a30 | .github/workflows/nuclei.yml | View secret | |
- | Bearer Token | 356172c | .github/workflows/nuclei.yml | View secret | |
- | Bearer Token | 5739a30 | .github/workflows/nuclei.yml | View secret | |
- | Bearer Token | 5678bc2 | .github/workflows/nuclei.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it. Commiter should remind the secret creation.
@@ -32,9 +32,7 @@ on: | |||
|
|||
workflow_dispatch: | |||
|
|||
# Since rules may change should run regularily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoKrish14 is that descheduling a common sense in tx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Copyright year not set to 2024 in kics.yml and README.md
- github code check failures in openapi.json (Array Without Maximum Number of Items (v3) Array schema has 'maxItems' set) 5 times
@RoKrish14 have to close this one as there were secrets in your git history |
WHAT
This PR introduces automated (and manual) DAST scanning using ZAP.
WHY
Manual DAST scanning is a tedious but critical effort. ZAP can be automated to perform these scans regularly and give more immediate feedback.
FURTHER NOTES
Please set the following (repository) secrets before activating/merging this PR (by personal communication with the requestor)