Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Automated DAST scanning #89

Closed

Conversation

drcgjung
Copy link
Contributor

WHAT

This PR introduces automated (and manual) DAST scanning using ZAP.

WHY

Manual DAST scanning is a tedious but critical effort. ZAP can be automated to perform these scans regularly and give more immediate feedback.

FURTHER NOTES

Please set the following (repository) secrets before activating/merging this PR (by personal communication with the requestor)

image

@drcgjung drcgjung added the enhancement New feature or request label Feb 19, 2024
Copy link

gitguardian bot commented Feb 19, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Bearer Token 5739a30 .github/workflows/nuclei.yml View secret
- Bearer Token 356172c .github/workflows/nuclei.yml View secret
- Bearer Token 5739a30 .github/workflows/nuclei.yml View secret
- Bearer Token 5678bc2 .github/workflows/nuclei.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor Author

@drcgjung drcgjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it. Commiter should remind the secret creation.

@@ -32,9 +32,7 @@ on:

workflow_dispatch:

# Since rules may change should run regularily
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoKrish14 is that descheduling a common sense in tx?

Copy link
Contributor

@Martin0815bla Martin0815bla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Copyright year not set to 2024 in kics.yml and README.md
  • github code check failures in openapi.json (Array Without Maximum Number of Items (v3) Array schema has 'maxItems' set) 5 times

@drcgjung
Copy link
Contributor Author

@RoKrish14 have to close this one as there were secrets in your git history

@drcgjung drcgjung closed this Feb 19, 2024
@drcgjung drcgjung deleted the feature/q-gate-dast-workflow branch February 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants