fix: improper null checks on the CustomAuthenticationConverter #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CustomAuthenticationConverter performed typecasting before the null checks, which would result in a NullPointerException if the return value before the cast was null. To remedy this issue I refactored the code block to use a functional style Optional object, which automatically returns an empty Set of GrantedAuthorities if any of value in the json tree is null or the return value does not match the desired type of Map<String, Object>.
Note that this converter is used to perform the authentication. So fixing this bug is security relevant.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: