Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Security assessment 23.12 #168

Merged
merged 1 commit into from
Nov 30, 2023
Merged

docs: Security assessment 23.12 #168

merged 1 commit into from
Nov 30, 2023

Conversation

pablosec
Copy link
Contributor

@pablosec pablosec commented Nov 22, 2023

Description

PR to add security assessment for release 23.12 to the /docs folder. Future security assessments will be added to the same subfolder.
The findings were added as issues and are linked from the report.
If there were any high- or maximum-risk findings, they would be submitted as security advisories (not the case in this assessment).

Please feel free to add comments for anything unclear or mis-understood or for any other remarks.

Thanks for participating in the re-assessment of MIW!

See also: eclipse-tractusx/sig-release#103

Closes #173

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@pablosec pablosec changed the base branch from main to develop November 22, 2023 15:03
@borisrizov-zf
Copy link
Contributor

@pablosec you'll have to rebase, as we've already synced the security.md in the previous merge.

@pablosec
Copy link
Contributor Author

@borisrizov-zf done

@OSchlienz @SSIRKC any remarks on the security assessment before merging?

@OSchlienz
Copy link

@pablosec nothing to add from my side, thanks!

@OSchlienz OSchlienz closed this Nov 24, 2023
@SSIRKC
Copy link

SSIRKC commented Nov 24, 2023

Hi @pablosec, since this PR is closed there isnt much to add from my side then. I am happy to assist in case you need feedback outside of this PR.

@pablosec pablosec reopened this Nov 24, 2023
@pablosec
Copy link
Contributor Author

Re-opened for @borisrizov-zf to merge. Thanks!

Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a rebase as #176 fixed a dependency incompatibility.

@borisrizov-zf
Copy link
Contributor

@pablosec I've edited the description, adding a close for an issue related to this review.

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pablosec
Copy link
Contributor Author

We'll need a rebase as #176 fixed a dependency incompatibility.

@borisrizov-zf done.

@borisrizov-zf
Copy link
Contributor

@OSchlienz please review, afterwards I'll merge this.

Copy link

@SSIRKC SSIRKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the made changes!

@borisrizov-zf borisrizov-zf merged commit a00386c into eclipse-tractusx:develop Nov 30, 2023
17 checks passed
Copy link

github-actions bot commented Dec 5, 2023

🎉 This PR is included in version 0.2.0-develop.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 7, 2023

🎉 This PR is included in version 0.3.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 7, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants