Feat: Create VC as JWT #260
Conversation
mustafasalfiti
force-pushed
the
feat/vc_asJwt
branch
from
6777f44
to
6b6fea3
Compare
mustafasalfiti
force-pushed
the
feat/vc_asJwt
branch
from
8661b7d
to
ed7d132
Compare
mustafasalfiti
force-pushed
the
feat/vc_asJwt
branch
from
4006c30
to
f120adb
Compare
|
should be with the latest ssi agent lib current (main) in order for the tests to work @borisrizov-zf |
.../org/eclipse/tractusx/managedidentitywallets/apidocs/IssuersCredentialControllerApiDocs.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/managedidentitywallets/service/PresentationService.java
Outdated
Show resolved
Hide resolved
|
@mustafasalfiti I'll ping you when the new release of the ssi-lib is out, so you can update. |
...n/java/org/eclipse/tractusx/managedidentitywallets/dto/IssueDismantlerCredentialRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/managedidentitywallets/service/CommonService.java
Outdated
Show resolved
Hide resolved
| [ | ||
| {"type":"TraceabilityCredential"}, | ||
| {"type":"SustainabilityCredential"}, | ||
| {"type":"ResiliencyCredential"}, |
There was a problem hiding this comment.
Note, with the new release this type does not exist anymore. From my point of view it does not make sense to follow the old standard - we should rather use the new credentials as per 24.05. release
There was a problem hiding this comment.
agree on that but in this PR it has nothing to do with the types of the VC, we can create a different PR for it, to fix that in the source code. this test was already there with a JSON-LD reponses, was only recreated to make sure it gives the response as JWT independent of the VC type.
There was a problem hiding this comment.
Agree, this PR is already large. Please create a new issue, link it here and we'll tackle that next.
On a side note: as soon as the IP check is done, I'll merge.
|
IP check link: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14592 Ready to merge. |
|
@mustafasalfiti please rebase to the latest develop version (there was a minor update merged a week ago). |
nitin-vavdiya
force-pushed
the
feat/vc_asJwt
branch
from
a3a1c33
to
bac5200
Compare
|
@borisrizov-zf Rebase is done |
| @Getter | ||
| @Setter | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Builder | ||
| public class IssueFrameworkCredentialRequest { |
There was a problem hiding this comment.
Formatting is off by one space. Please re-check this (and other files), rebase and ping me.
There was a problem hiding this comment.
@borisrizov-zf formatting is done
I think a rebase is not needed as there has been no change in develop branch since the last rebase. Am I right?
|
|
@nitin-vavdiya Hi, I'm doing manual tests. If all goes well, I'll merge and notify you. |
|
Dash review required |
|
🎉 This PR is included in version 0.5.0-develop.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
In the Controllers, an option has been added to generate a VC as a JWT (JSON Web Token). By default, this option is set to false. When set to true, the response will be a JWT containing the VC.
Additionally, certain exception handling has been revised and corrected due to the integration of the new SSI-lib
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: