Abstract key storage and signing operations to facilitate different key storage types #291
Conversation
PManaras
changed the title
...main/java/org/eclipse/tractusx/managedidentitywallets/ManagedIdentityWalletsApplication.java
Outdated
Show resolved
Hide resolved
|
|
License headers need to be updated in changed files |
nitin-vavdiya
force-pushed
the
pr-upstream-keystorage
branch
from
eea4b49
to
1c6e332
Compare
|
@thackerronak @nitin-vavdiya We're ok to rebase this branch and do final testing before we merge. |
Rebase is done, fixing failing test cases, will let you know once it is ready to merge |
|
@borisrizov-zf |
CHANGELOG.md
Outdated
| @@ -13,6 +13,82 @@ | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * add asJwt as query param and fix | |||
There was a problem hiding this comment.
Where do all of these entries come from?
There was a problem hiding this comment.
This is merge commit I think after rebase
| @@ -33,20 +33,43 @@ public interface WalletKeyRepository extends BaseRepository<WalletKey, Long> { | |||
| /** | |||
| * Gets by wallet id and algorithm. | |||
| * | |||
| * @param id the id | |||
| * param algorithm the algorithm | |||
| * @param id the id param algorithm the algorithm | |||
There was a problem hiding this comment.
Looks like a formatting issue here.
…ICE_TYPE & LOCAL_SIGNING_KEY_STORAGE_TYPE to docker env
nitin-vavdiya
force-pushed
the
pr-upstream-keystorage
branch
from
fcf86af
to
af87ecb
Compare
|
|
🎉 This PR is included in version 0.5.0-develop.18 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR introduces support for implementing different types of keystorages via the newly KeyProvider interface. This interface can be used to retrieve keys from different types of storages, i.e. remote vaults, file-system, database.
The newly created SigningService can be used to implement different types of signature processes. The standard signature process is "LOCAL" meaning the MIW will use keys provided by the keyprovider to sign VP/VC locally.
This PR also adds to new properties to application.yaml (authoritySigningServiceType (defaults to "LOCAL), localSigningKeyStorageType (defaults to DB). These additions are also reflected in the corresponding env-files.
The database entity Wallet was updated and now contains a new field signingServiceType that reflects which wallet uses which signatureServices. The new field is introduced via a new database migration (v3) and sets the signing_service_type to "LOCAL" for all existing wallets. This means: with the standard configuration the MIW will act as before.
this PR includes changes made in the PR on the main-branch
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
This PR is qual to PR285 from a different merge source