Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(offerSubscriptionDetail): responding External Service details (#75) #1081

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Oct 21, 2024

Description

External Service details missing from the API response

API: /api/services/{serviceId}/subscription/{subscriptionId}/provider
Method: GET
Response Data:

{
    "id": "db1a7759-cc33-4a9a-a5c8-f89430886af9",
    "offerSubscriptionStatus": "ACTIVE",
    "name": "Jupiter Test Pumpkin",
    "customer": "Jupiter Test2 V",
    "bpn": "BPNL00000000071A",
    "contact": [
        "[email protected]"
    ],
    "technicalUserData": [
        {
            "id": "a8962456-56bb-43e5-bd95-ee0b1115216b",
            "name": "sa30",
            "permissions": [
                "BPDM Pool Admin"
            ]
        }
    ]
}

Why

External Service details missing in the response.
image

Issue

Ref: 1080
Cherry-picked commit: 67814344fcab57f3a401db4f84211b81d7604aca

Corresponding Configuration PR

eclipse-tractusx/portal#460

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

@tfjanjua tfjanjua self-assigned this Oct 21, 2024
@tfjanjua tfjanjua added the bug Something isn't working label Oct 21, 2024
@evegufy evegufy added this to the Release 2.3.0 (24.12) milestone Oct 24, 2024
@Phil91 Phil91 changed the base branch from main to release/v2.3.0-RC2 October 25, 2024 05:45
@tfjanjua tfjanjua force-pushed the fix/1080-respond-external-service-details branch from f5ec497 to 853a561 Compare October 29, 2024 11:44
@ntruchsess ntruchsess self-assigned this Nov 5, 2024
@evegufy evegufy changed the base branch from release/v2.3.0-RC2 to main November 13, 2024 14:41
@ntruchsess ntruchsess force-pushed the fix/1080-respond-external-service-details branch from a05159c to 333d941 Compare November 13, 2024 21:47
@ntruchsess ntruchsess force-pushed the fix/1080-respond-external-service-details branch 3 times, most recently from 7bcdefa to b7f08ed Compare November 13, 2024 22:42
@ntruchsess ntruchsess force-pushed the fix/1080-respond-external-service-details branch from b7f08ed to 684dc51 Compare November 13, 2024 22:52
Copy link

sonarcloud bot commented Nov 13, 2024

@ntruchsess ntruchsess merged commit cf3aa20 into eclipse-tractusx:main Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants