Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add checks for serviceAccount and companyUsers to endpoints #148

Merged
merged 2 commits into from
Aug 4, 2023
Merged

feat: add checks for serviceAccount and companyUsers to endpoints #148

merged 2 commits into from
Aug 4, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 18, 2023

Description

add check whether an endpoint should only be callable for a service account user
add check whether an endpoint should only be callable for a company user

Why

To enhance the endpoint security for endpoints that either are only callable by a company user or by a service account user

Issue

N/A - Jira Ticket: CPLP-2863

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 marked this pull request as ready for review July 18, 2023 09:13
@Phil91 Phil91 requested a review from ntruchsess July 18, 2023 09:13
@Phil91 Phil91 deleted the branch eclipse-tractusx:release/v1.6.0-RC5 July 21, 2023 13:03
@Phil91 Phil91 closed this Jul 21, 2023
@Phil91 Phil91 reopened this Jul 21, 2023
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC2 to release/v1.6.0-RC3 July 21, 2023 14:00
@Phil91 Phil91 force-pushed the feature/CPLP-2863-endpoint-accessibility branch from 4b74163 to a54f4d8 Compare July 25, 2023 06:40
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC3 to release/v1.6.0-RC4 July 25, 2023 09:41
@ntruchsess ntruchsess self-assigned this Jul 28, 2023
@Phil91 Phil91 force-pushed the feature/CPLP-2863-endpoint-accessibility branch from a54f4d8 to 4f0344f Compare July 31, 2023 12:32
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC4 to release/v1.6.0-RC5 July 31, 2023 13:12
@Phil91 @ntruchsess
feat: add checks for serviceAccount and companyUsers to endpoints
34cc8fd 
add check whether an endpoint should only be callable for a service account user
add check whether an endpoint should only be callable for a company user

Refs: CPLP-2863
@Phil91 @ntruchsess
chore: add identity check to policy CompanyUser and ServiceAccount
4b1cd20 
Refs: CPLP-2863
@ntruchsess ntruchsess force-pushed the feature/CPLP-2863-endpoint-accessibility branch from 4f0344f to 4b1cd20 Compare July 31, 2023 13:20
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Phil91 Phil91 requested a review from ntruchsess August 1, 2023 06:44
@jjeroch jjeroch added the priority PR needs to prioritized at review label Aug 3, 2023
@ntruchsess ntruchsess merged commit 093a80d into eclipse-tractusx:release/v1.6.0-RC5 Aug 4, 2023
4 of 5 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-2863-endpoint-accessibility branch August 4, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees

@ntruchsess ntruchsess

Labels
priority PR needs to prioritized at review rel 1.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @jjeroch