fix(invitedUsers): filter deleted users for invitedUsers endpoint #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phil91
force-pushed
the
bugfix/CPLP-2986-inviteduser
branch
from
44b78f8
to
e0cca89
Compare
ntruchsess
requested changes
Jul 28, 2023
| invitationStatus.Id, | ||
| companyuser.Email | ||
| )) | ||
| _dbContext.Invitations |
There was a problem hiding this comment.
I suggest:
public IAsyncEnumerable<InvitedUserDetail> GetInvitedUserDetailsUntrackedAsync(Guid applicationId) =>
_dbContext.Invitations
.AsNoTracking()
.Where(invitation => invitation.CompanyApplicationId == applicationId && invitation.CompanyUser!.Identity!.UserStatusId != UserStatusId.DELETED)
.Select(invitation => new InvitedUserDetail(
invitation.CompanyUser!.Identity!.UserEntityId,
invitation.InvitationStatusId,
invitation.CompanyUser.Email))
.AsAsyncEnumerable();
|
|
||
| var result = await sut.GetInvitedUserDetailsUntrackedAsync(_applicationId).ToListAsync().ConfigureAwait(false); | ||
|
|
||
| result.Should().NotBeNull(); |
There was a problem hiding this comment.
I suggest:
result.Should().HaveCount(2)
.And.Satisfy(
x => x.EmailId == "[email protected]" && x.InvitationStatus == InvitationStatusId.CREATED,
x => x.EmailId == "[email protected]" && x.InvitationStatus == InvitationStatusId.CREATED);
(there's no point in asserting 'NotBeNull()' if there are more asserts that implicitly fail if NotBeNull is not satisfied)
Refs: CPLP-2986
Refs: CPLP-2986
|
Kudos, SonarCloud Quality Gate passed!
|
ntruchsess
approved these changes
Jul 31, 2023
ntruchsess
merged commit 60c9b3a
into
eclipse-tractusx:release/v1.6.0-RC4
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the deleted users from the invitedUsers request
Why
Deleted users don't have an userEntityId, therefor the request will fail when keycloak is requested for the user informations
Issue
N/A - Jira Issue: CPLP-2986
Checklist