Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openUrl): Add Endpoints for public apis foreach service #161

Merged
merged 12 commits into from
Aug 11, 2023
Merged

feat(openUrl): Add Endpoints for public apis foreach service #161

merged 12 commits into from
Aug 11, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 21, 2023

Description

Add GET endpoint to receive public apis foreach service

Why

To be able to display the public available urls in the frontend a new endpoint was needed

Issue

N/A - Jira Issue: CPLP-2958

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 changed the title Feature/cplp 2958 open apis feat(openUrl): Add Endpoints for public apis foreach service Jul 21, 2023
@evegufy evegufy mentioned this pull request Jul 22, 2023
Closed
6 tasks
@Phil91 Phil91 marked this pull request as ready for review July 24, 2023 06:30
@Phil91 Phil91 requested a review from ntruchsess July 24, 2023 06:30
@Phil91 Phil91 force-pushed the feature/CPLP-2958-open-apis branch from c974af0 to 73191d0 Compare July 25, 2023 07:12
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC3 to release/v1.6.0-RC4 July 25, 2023 09:42
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC4 to release/v1.6.0-RC5 July 31, 2023 13:12
@Phil91 Phil91 force-pushed the feature/CPLP-2958-open-apis branch from 73191d0 to f93259f Compare August 1, 2023 07:35
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC5 to release/v1.6.0-RC6 August 7, 2023 08:53
@Phil91 Phil91 force-pushed the feature/CPLP-2958-open-apis branch from 71b6b28 to bea193f Compare August 8, 2023 13:52
@Phil91 Phil91 requested a review from ntruchsess August 8, 2023 14:25
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC6 to release/v1.6.0-RC7 August 11, 2023 11:22
@Phil91
chore: add open api endpoint for cx members
c81eb8e 
add endpoint to all services /api/info to receive the api endpoints filtered for the companyRole

Refs: CPLP-2958
@Phil91
feat(openUrl): Add Endpoints for public apis foreach service
c703c3d 
Add GET endpoint to receive public apis foreach service

Refs: CPLP-2958
@Phil91
chore: suppress sonar warnings
83f8860 
suppress sonar warnings for unit test asserts

Refs: CPLP-2958
@Phil91
tests(openUrl): disable parallelization for public url tests
1363446 
due to timing issues the parallelization for the public url tests have been disabled

Refs: CPLP-2958
@Phil91
tests: fix unit tests
5570767 
Refs: CPLP-2958
@Phil91
tests: adjust unit tests
aec4cc2 
Refs: CPLP-2958
@Phil91 Phil91 force-pushed the feature/CPLP-2958-open-apis branch from 660efc8 to 9d0ded9 Compare August 11, 2023 11:30
Phil91 and others added 3 commits August 11, 2023 13:32
@Phil91
feat(openUrl): Add Endpoints for public apis foreach service
eb0ae21 
Add GET endpoint to receive public apis foreach service

Refs: CPLP-2958
@Phil91
test(openApi): add unit tests for GetPublicUrls
2e6523d 
Refs: CPLP-2958
@ntruchsess @Phil91
cleanup
3f5960d
@Phil91 Phil91 force-pushed the feature/CPLP-2958-open-apis branch from 9d0ded9 to 3f5960d Compare August 11, 2023 11:38
@Phil91 Phil91 requested a review from ntruchsess August 11, 2023 12:31
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ntruchsess ntruchsess merged commit 39c81fc into eclipse-tractusx:release/v1.6.0-RC7 Aug 11, 2023
5 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-2958-open-apis branch August 11, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees
No one assigned
Labels
rel 1.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @jjeroch