Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bpdm): adjust bpdm service calls to new service #164

Merged
merged 9 commits into from
Jul 31, 2023
Merged

feat(bpdm): adjust bpdm service calls to new service #164

merged 9 commits into from
Jul 31, 2023

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 24, 2023 •
edited
Loading

Description

Change BPDM-Service Calls for the new Service
Align Service Models

Why

structure of bpdm service has changed, therefor the models have been aligned

Issue

N/A - Jira Ticket: CPLP-2976

Corresponding CD PR

#53

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 marked this pull request as ready for review July 24, 2023 14:34
@Phil91 Phil91 requested a review from ntruchsess July 24, 2023 14:34
@Phil91 Phil91 changed the base branch from release/v1.6.0-RC3 to release/v1.6.0-RC4 July 25, 2023 09:43
@Phil91 Phil91 mentioned this pull request Jul 26, 2023
Merged
2 tasks
ntruchsess
ntruchsess requested changes Jul 27, 2023
View reviewed changes
src/externalsystems/Bpdm.Library/BpnAccess.cs Outdated Show resolved Hide resolved
src/externalsystems/Bpdm.Library/BpnAccess.cs Outdated Show resolved Hide resolved
@Phil91 Phil91 requested a review from ntruchsess July 29, 2023 15:11
Phil91 and others added 9 commits July 31, 2023 14:36
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ntruchsess ntruchsess merged commit 9dc4d5a into eclipse-tractusx:release/v1.6.0-RC4 Jul 31, 2023
5 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-2976-bpdm branch July 31, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees

@ntruchsess ntruchsess

Labels
rel 1.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @jjeroch