Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): link creatorId to identity #170

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 26, 2023

Description

The database foreign key of creatorId is not linked to a companyUser anymore, instead it's now linked to a identity

Why

Previously the creator of a notification was linked to a companyUser which results in errors when executing the autoSetup with a technicalUser, thats fixed with this pr

Issue

N/A - Jira Issue: CPLP-3042

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

previously the creator of a notification was linked to a companyUser
which results in errors when executing the autoSetup with a
technicalUser, thats fixed with this pr

Refs: CPLP-3042
@jjeroch jjeroch added priority PR needs to prioritized at review rel 1.6.0 labels Jul 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 marked this pull request as ready for review July 26, 2023 14:59
@Phil91 Phil91 requested a review from ntruchsess July 26, 2023 14:59
@ntruchsess ntruchsess merged commit 7d9dafd into eclipse-tractusx:release/v1.6.0-RC4 Jul 27, 2023
3 checks passed
@ntruchsess ntruchsess deleted the bugfix/CPLP-3042-notifications branch July 27, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review rel 1.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants