Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssi): adjust certificateTypes endpoint #171

Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 26, 2023

Description

enhance businessLogic of the GET /administration/companydata/certificateTypes to return only the possible certificateTypes

Why

To show the user only the possible certificates he can request

Issue

N/A - Jira Issue: CPLP-3002

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 marked this pull request as ready for review July 26, 2023 14:59
@Phil91 Phil91 requested a review from ntruchsess July 26, 2023 14:59
enhance businessLogic of the GET /administration/companydata/certificateTypes to return only the possible certificateTypes

Refs: CPLP-3002
@Phil91 Phil91 force-pushed the feature/CPLP-3002-certificateTypes branch from fd7dffc to 20e063f Compare August 1, 2023 06:46
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 merged commit fd35b70 into eclipse-tractusx:dev Aug 8, 2023
5 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3002-certificateTypes branch August 8, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants