Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps and services):- post offerId/agreementconsent #173

Conversation

qxz2mqe
Copy link
Contributor

@qxz2mqe qxz2mqe commented Jul 28, 2023

Description

aoi/apps/appreleaseproces/consent/appid/agrremntconsent and aoi/apps/appreleaseproces/consent/appid/agrremntconsent
was throwing 500 internal service error due to foreign key constraint .

Why

The exception was thrown due to qury condtion of providercompany.idenriries .companyuserid singleordefault which never ensure the comparison.if companyuserid is null then it will give foreign key issue.

Issue

CPLP-3018

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@qxz2mqe qxz2mqe marked this pull request as ready for review July 28, 2023 07:10
@ntruchsess ntruchsess self-assigned this Jul 28, 2023
@ntruchsess ntruchsess force-pushed the fix/CPLP-3018-app-releaseconsent-agreement-500-error branch from a95ebbf to c1c1752 Compare July 28, 2023 09:54
@ntruchsess ntruchsess force-pushed the fix/CPLP-3018-app-releaseconsent-agreement-500-error branch from c1c1752 to 4ab4564 Compare July 28, 2023 10:15
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ntruchsess ntruchsess merged commit 0d4372f into eclipse-tractusx:release/v1.6.0-RC4 Jul 28, 2023
5 checks passed
@ntruchsess ntruchsess deleted the fix/CPLP-3018-app-releaseconsent-agreement-500-error branch July 28, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants