feat(OfferService)! : unsubscribe OfferSubscription for apps and service #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phil91
requested changes
Aug 4, 2023
src/portalbackend/PortalBackend.DBAccess/Repositories/OfferSubscriptionsRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/IOfferSubscriptionsRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/OfferSubscriptionsRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/OfferSubscriptionsRepository.cs
Outdated
Show resolved
Hide resolved
VPrasannaK94
force-pushed
the
feature/CPLP-3027-unsubscribe-apps-service
branch
from
5ef2ca9
to
961bc95
Compare
|
@VPrasannaK94 it seems like there's one commit in the branch which doesn't belong there (3957eaf), could you have a look at that? |
OfferSubscription for apps and service Ref: CPLP-3027
VPrasannaK94
force-pushed
the
feature/CPLP-3027-unsubscribe-apps-service
branch
from
961bc95
to
dcfec84
Compare
Phil91
requested changes
Aug 9, 2023
| .MustHaveHappenedTwiceExactly(); | ||
| A.CallTo(() => _userRepository.AttachAndModifyIdentity(A<Guid>._, A<Action<Identity>>._, A<Action<Identity>>._)) | ||
| .MustHaveHappenedTwiceExactly(); | ||
| } |
There was a problem hiding this comment.
Please add a check whether the connectors and identities have been updated successfully.
e.g.:
'connectors.Should().AllSatisfy(x => x.StatusId == ConnectorStatusId.INACTIVE);'
There was a problem hiding this comment.
The same applies for the offersubscription
|
Kudos, SonarCloud Quality Gate passed!
|
Phil91
approved these changes
Aug 16, 2023
jjeroch
added a commit
to catenax-ng/tx-portal-assets
that referenced
this pull request
Aug 21, 2023
Documentation of "unsubscribe" function linked to: eclipse-tractusx/portal-backend#180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unsubscribe OfferSubscription for apps and service
Why
when we trigger unsubscribe endpoint for Apps and Service , we put offerSubscription to Inactive.
Issue
CPLP-3027
Checklist
Please delete options that are not relevant.