Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user): save userid of ipd #427

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat(user): save userid of ipd #427

merged 2 commits into from
Jan 25, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jan 23, 2024 •
edited
Loading

Description

  • save the userid for each idp for a specific the user
  • return userid of an idp with the idps display name

Why

to improve transparency
support the user in error cases
allows us in future to also support "change" on the same

Issue

#430

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the feature/CPLP-3401-idp-provider-userid branch 2 times, most recently from b7e2968 to 8df416f Compare January 23, 2024 09:38
@Phil91 Phil91 linked an issue Jan 23, 2024 that may be closed by this pull request
Store IdP UserID for reference and User Management #430
Closed
6 tasks
@Phil91 Phil91 changed the base branch from release/v1.8.0-RC3 to release/v1.8.0-RC4 January 23, 2024 14:51
@Phil91 Phil91 force-pushed the feature/CPLP-3401-idp-provider-userid branch 2 times, most recently from 2a5025b to 5307946 Compare January 24, 2024 07:58
@Phil91
feat(user): save userid of ipd
6af5772 
* save the userid for each idp for a specific the user
* add displayName to iamIdentityProvider
* return userid of an idp with the idps display name

Refs: eclipse-tractusx#430
@Phil91 Phil91 force-pushed the feature/CPLP-3401-idp-provider-userid branch from 5307946 to 6af5772 Compare January 24, 2024 14:02
@ntruchsess ntruchsess force-pushed the feature/CPLP-3401-idp-provider-userid branch from 3126553 to 8151a11 Compare January 24, 2024 18:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit 4cc892e into eclipse-tractusx:release/v1.8.0-RC4 Jan 25, 2024
6 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-3401-idp-provider-userid branch January 25, 2024 07:48
@ntruchsess ntruchsess mentioned this pull request Jan 25, 2024
Closed
6 tasks
@Phil91 Phil91 added the breaking change PR shall be handled with extra care as it breaks existing functionality label Jan 31, 2024
@ntruchsess ntruchsess mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees
No one assigned
Labels
breaking change PR shall be handled with extra care as it breaks existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store IdP UserID for reference and User Management
2 participants
@Phil91 @ntruchsess