Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sonar): fix code-scanner findings #437 #531

Merged
merged 10 commits into from
Mar 6, 2024
Merged

chore(sonar): fix code-scanner findings #437 #531

merged 10 commits into from
Mar 6, 2024

Conversation

ntruchsess
Copy link
Contributor

@ntruchsess ntruchsess commented Feb 23, 2024 •
edited
Loading

Description

  • remove GET /api/user/app/{appId}/roles
  • remove PUT /api/user/app/{appId}/roles
  • findings from sonar were fixed
  • findings from codeql were fixed

corresponding PR in portal CD-repository: eclipse-tractusx/portal#210

Why

removal of obsolete code and fixing code-scanner issues increases maintainability.

Issue

#437

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • [X ] I have checked that new and existing tests pass locally with my changes

@evegufy evegufy changed the base branch from release/v1.8.0 to dev February 24, 2024 09:23
@ntruchsess ntruchsess force-pushed the chore/437-sonar-findings branch 16 times, most recently from 04c1ffc to d7e2860 Compare February 29, 2024 18:21
@ntruchsess ntruchsess force-pushed the chore/437-sonar-findings branch 3 times, most recently from 8f57efb to 5aee489 Compare February 29, 2024 19:56
@ntruchsess ntruchsess changed the title chore(user): remove obsolete endpoints chore(sonar): fix code-scanner findings Feb 29, 2024
@ntruchsess ntruchsess changed the title chore(sonar): fix code-scanner findings chore(sonar): fix code-scanner findings #437 Feb 29, 2024
@ntruchsess ntruchsess marked this pull request as ready for review February 29, 2024 21:15
Phil91
Phil91 reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve as soon as CD-PR is there.

This was referenced Mar 4, 2024
Closed
Merged
@ntruchsess ntruchsess requested a review from Phil91 March 4, 2024 18:59
Phil91
Phil91 previously approved these changes Mar 5, 2024
View reviewed changes
@ntruchsess ntruchsess mentioned this pull request Mar 5, 2024
Merged
4 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess requested a review from Phil91 March 5, 2024 16:37
@ntruchsess ntruchsess merged commit 0e26043 into eclipse-tractusx:dev Mar 6, 2024
8 checks passed
@ntruchsess ntruchsess deleted the chore/437-sonar-findings branch March 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil91 Phil91 Phil91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntruchsess @Phil91