Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checklist): add new checklist steps #576

Merged
merged 7 commits into from
Apr 17, 2024
Merged

feat(checklist): add new checklist steps #576

merged 7 commits into from
Apr 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Mar 21, 2024 •
edited
Loading

Description

  • extend application checklist with BpnCredentialCreation and MembershipCredentialCreation
  • add endpoint to trigger email sending
  • add endpoint to add notifications for a specific user

Why

To do the initial setup of a company its needed that the wallet of the company has the signed bpn and membership credentials, therefor the process was adjusted.

Issue

Refs: #564

Corresponding CD PR

#242

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 mentioned this pull request Mar 27, 2024
Merged
4 tasks
@ntruchsess ntruchsess linked an issue Apr 2, 2024 that may be closed by this pull request
SSI - Add registration step to create credentials #564
Closed
@jjeroch jjeroch added the priority PR needs to prioritized at review label Apr 3, 2024
@Phil91 Phil91 requested a review from ntruchsess April 4, 2024 12:04
@Phil91 Phil91 mentioned this pull request Apr 9, 2024
Merged
4 tasks
@ntruchsess ntruchsess self-assigned this Apr 11, 2024
@evegufy evegufy changed the base branch from dev to release/v2.0.0-RC2 April 15, 2024 07:28
@evegufy evegufy added this to the Release 24.05 (dev) milestone Apr 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit f23b550 into eclipse-tractusx:release/v2.0.0-RC2 Apr 17, 2024
11 checks passed
@ntruchsess ntruchsess deleted the feature/564-checklist branch April 17, 2024 11:03
@Phil91 Phil91 mentioned this pull request Apr 17, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

Assignees

@ntruchsess ntruchsess

Labels
priority PR needs to prioritized at review
Projects
None yet
Milestone
Release 2.0.0 (24.05)
Development

Successfully merging this pull request may close these issues.

SSI - Add registration step to create credentials
4 participants
@Phil91 @ntruchsess @evegufy @jjeroch