Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processWorker): create process worker package #998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 16, 2024

Description

  • create packages for the process worker library
  • adjusting code to use the new library

Why

To provide the process worker functionality to other products as well

Issue

#240

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

context.PortalRepositories.GetInstance<IProcessStepRepository>().AttachAndModifyProcessSteps(
ModifyStepStatusRange(context.ProcessSteps.Where(step => step.ProcessStepTypeId == context.ProcessStepTypeId.Value), ProcessStepStatusId.DONE));
context.ProcessRepositories.GetInstance<IProcessStepRepository<TProcessTypeId, TProcessStepTypeId>>().AttachAndModifyProcessSteps(
ModifyStepStatusRange(context.ProcessSteps.Where(step => step.ProcessStepTypeId.Equals(context.ProcessStepTypeId.Value)), ProcessStepStatusId.DONE));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
context.ProcessStepTypeId
may be null at this access because it has a nullable type.
@Phil91 Phil91 force-pushed the process-worker branch 2 times, most recently from c37c866 to 277d39f Compare September 17, 2024 12:58
@Phil91 Phil91 force-pushed the process-worker branch 2 times, most recently from a33c0d3 to 4873665 Compare September 27, 2024 14:00
@Phil91 Phil91 marked this pull request as ready for review September 27, 2024 14:00
@Phil91 Phil91 force-pushed the process-worker branch 4 times, most recently from b6cdc0d to 365e03c Compare October 4, 2024 09:47
@evegufy evegufy added this to the Release 25.03 milestone Oct 24, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants