fix(Service Release): prevent only spaces in short & long description (…

…#1092)
eclipse-tractusx · Sep 17, 2024 · 6c4a0f9 · 6c4a0f9
1 parent 531f6fb
commit 6c4a0f9
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Bugfixes
 
+- **Service Release Process**
+  - Updated description regex & validation error message to prevent only spaces in short & long description
 - **OSP Consent form**
   - Display invited company name in OSP consent form (Previously hard coded with 'BMW') [#1083](https://github.com/eclipse-tractusx/portal-frontend/pull/1083)
   - Fixed missing street number in form [#1081](https://github.com/eclipse-tractusx/portal-frontend/issues/1081)

diff --git a/src/assets/locales/de/servicerelease.json b/src/assets/locales/de/servicerelease.json
@@ -90,6 +90,7 @@
     "maximum": "Maximum",
     "charactersAllowed": " characters allowed",
     "validCharactersIncludes": "Valid characters includes: ",
+    "spaceAloneNotAllowed": " and spaces alone are not allowed",
     "isMandatory": " is mandatory",
     "fileUploadIsMandatory": "File upload is mandatory",
     "error": {

diff --git a/src/assets/locales/en/servicerelease.json b/src/assets/locales/en/servicerelease.json
@@ -90,6 +90,7 @@
     "maximum": "Maximum",
     "charactersAllowed": " characters allowed",
     "validCharactersIncludes": "Valid characters includes: ",
+    "spaceAloneNotAllowed": " and spaces alone are not allowed",
     "isMandatory": " is mandatory",
     "fileUploadIsMandatory": "File upload is mandatory",
     "error": {

diff --git a/src/components/shared/basic/ReleaseProcess/OfferCard/index.tsx b/src/components/shared/basic/ReleaseProcess/OfferCard/index.tsx
@@ -472,7 +472,8 @@ export default function OfferCard() {
                         )}`,
                         pattern: `${t(
                           'serviceReleaseForm.validCharactersIncludes'
-                        )} ${'a-zA-ZÀ-ÿ0-9 !?@&#\'"()_-=/*.,;:'}`,
+                        )} ${'a-zA-ZÀ-ÿ0-9 !?@&#\'"()_-=/*.,;:'}
+                        ${t('serviceReleaseForm.spaceAloneNotAllowed')}`,
                         maxLength: `${t('serviceReleaseForm.maximum')} 120 ${t(
                           'serviceReleaseForm.charactersAllowed'
                         )}`,

diff --git a/src/components/shared/basic/ReleaseProcess/OfferPage/index.tsx b/src/components/shared/basic/ReleaseProcess/OfferPage/index.tsx
@@ -317,7 +317,8 @@ export default function OfferPage({
                     )}`,
                     pattern: `${t(
                       'serviceReleaseForm.validCharactersIncludes'
-                    )} ${'a-zA-ZÀ-ÿ0-9 !?@&#\'"()[]_-+=<>/*.,;:'}`,
+                    )} ${'a-zA-ZÀ-ÿ0-9 !?@&#\'"()[]_-+=<>/*.,;:'} 
+                    ${t('serviceReleaseForm.spaceAloneNotAllowed')}`,
                   }}
                   maxLength={longDescriptionMaxLength}
                 />

diff --git a/src/types/Patterns.ts b/src/types/Patterns.ts
@@ -81,10 +81,10 @@ export const Patterns = {
   offerCard: {
     serviceName: /^[^-\s()'"#@.&](?!.*[%&?,';:!\s-]{2}).{2,200}$/,
     serviceType: /^([A-Za-z])$/,
-    shortDescription: /^.{10,120}$/,
+    shortDescription: /^(?! *$).{10,120}$/,
   },
   offerPage: {
-    longDescription: /^.{10,1999}$/,
+    longDescription: /^(?! *$).{10,1999}$/,
   },
   appPage: {
     longDescriptionEN: