bugfix(technical integration): error message fix (#344)

eclipse-tractusx · Nov 13, 2023 · aeebf3c · aeebf3c
1 parent 1dcf558
commit aeebf3c
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## 1.7.0-RC3
 
+- App release process
+  - error message fix in technical integration
 - IDP User Migration
   - Extended error handling of the api response message implemented
   - Included csv file upload validation of csv header row content

diff --git a/src/assets/locales/de/main.json b/src/assets/locales/de/main.json
@@ -1104,7 +1104,7 @@
         "getHelp": "Get Help",
         "deleteOverlayContent": "Deletion will not be reversable, do you still want to delete?",
         "roleUploadIsMandatory": "Role upload is mandatory",
-        "technicalUserSetupMandatory": "Please select atleast one technical user setup",
+        "technicalUserSetupMandatory": "Bitte wählen Sie mindestens ein technisches Benutzer-Setup aus",
         "roleDeleteSuccessMessage": "Role deleted successfully",
         "technicalUserProfileError": "Error while updating technical user profiles",
         "roleUpdateError": "Error while updating roles"

diff --git a/src/assets/locales/de/servicerelease.json b/src/assets/locales/de/servicerelease.json
@@ -60,7 +60,7 @@
   "technicalIntegration": {
     "headerTitle": "Technical Integration",
     "headerDescription": "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard .Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard .",
-    "technicalUserSetupMandatory": "Please select atleast one technical user setup",
+    "technicalUserSetupMandatory": "Bitte wählen Sie mindestens ein technisches Benutzer-Setup aus",
     "technicalUserProfileError": "Error while updating technical user profiles"
   },
   "step4": {

diff --git a/src/assets/locales/en/main.json b/src/assets/locales/en/main.json
@@ -79,7 +79,7 @@
     "idp_status_change_info": "{{status}} identity provider",
     "idp_status_change_intro2": "Are you sure you want to enable this idp?",
     "idp_status_change_intro1": "Disable the idp will always result into the deactivation, but not deletion. You can always enable it again",
-    "idp_status_tooltip_info": "Atleast one company service needs to enabled",
+    "idp_status_tooltip_info": "At least one company service needs to enabled",
     "idp_test_intro1": "Identity Provider was successfully created.",
     "idp_test_intro2": "The IdP is disabled for now and get enabled below.",
     "idp_test_description": "Please note, before enabling the Idp and trying to login, you need to setup the Idp connection on you side as well and connect your CX user to the IdP connection. To enable the same, please fillout the fields below.",
@@ -1068,7 +1068,7 @@
         "getHelp": "Get Help",
         "deleteOverlayContent": "Deletion will not be reversable, do you still want to delete?",
         "roleUploadIsMandatory": "Role upload is mandatory",
-        "technicalUserSetupMandatory": "Please select atleast one technical user setup",
+        "technicalUserSetupMandatory": "Please select at least one technical user setup",
         "roleDeleteSuccessMessage": "Role deleted successfully",
         "technicalUserProfileError": "Error while updating technical user profiles",
         "roleUpdateError": "Error while updating roles"

diff --git a/src/components/shared/basic/ReleaseProcess/TechnicalIntegration/index.tsx b/src/components/shared/basic/ReleaseProcess/TechnicalIntegration/index.tsx
@@ -134,13 +134,16 @@ export default function TechnicalIntegration() {
 
   const handleCheckedUserProfiles = (checked: boolean, item: userRolesType) => {
     const isSelected = techUserProfiles?.includes(item.roleId)
+    let selectedProfiles: string[] = []
     if (!isSelected && checked) {
-      setTechUserProfiles([...techUserProfiles, item.roleId])
+      selectedProfiles = [...techUserProfiles, item.roleId]
     } else if (isSelected && !checked) {
       const oldTechUserProfiles = [...techUserProfiles]
       oldTechUserProfiles.splice(oldTechUserProfiles.indexOf(item.roleId), 1)
-      setTechUserProfiles([...oldTechUserProfiles])
+      selectedProfiles = [...oldTechUserProfiles]
     }
+    setEnableUserProfilesErrorMessage(selectedProfiles?.length === 0)
+    setTechUserProfiles(selectedProfiles)
   }
 
   const handleSaveSuccess = (buttonLabel: string) => {
@@ -155,7 +158,10 @@ export default function TechnicalIntegration() {
     submitData: unknown,
     buttonLabel: string
   ) => {
-    if (buttonLabel === ButtonLabelTypes.SAVE) {
+    if (
+      buttonLabel === ButtonLabelTypes.SAVE &&
+      (data?.length === 0 || techUserProfiles.length === 0)
+    ) {
       data?.length === 0 && setEnableErrorMessage(true)
       techUserProfiles.length === 0 && setEnableUserProfilesErrorMessage(true)
     } else if (