Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service marketplace): list all active services #1134

Merged

Conversation

Usmanfee
Copy link
Contributor

@Usmanfee Usmanfee commented Sep 20, 2024

Description

Service marketplace should have all the active services but now with implemented solution we can see all the services.
Changelog entry:
- fixed service marketplace to display all active available servicesp[#1143](https://github.com/eclipse-tractusx/portal-frontend/issues/1143)

Why

Service Marketplace hasn't have the all the active services available throughout from all the service provider. Now, for each service provider marketplace we can observe all the services.

Issue

#1143

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@Usmanfee Usmanfee changed the title fix: service marketplace active list --wip fix(UI): service marketplace active list Sep 23, 2024
@Usmanfee Usmanfee force-pushed the fix/PM2-853-service-marketplace-active-list branch from db2dae4 to f8a893a Compare September 23, 2024 09:06
@Usmanfee Usmanfee marked this pull request as ready for review September 23, 2024 14:53
@Usmanfee Usmanfee marked this pull request as draft September 23, 2024 14:54
Copy link
Contributor

@ss-nikunj ss-nikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@saadanzari saadanzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. lgtm

@Usmanfee Usmanfee marked this pull request as ready for review September 24, 2024 08:17
@Usmanfee
Copy link
Contributor Author

@ma3u @oyo can you please review this PR ?
currently, I can't add you in this PR as reviewer. However, I have already created the ticket to become tractusx contributor: eclipse-tractusx/sig-infra#547 . Thank you!

@evegufy evegufy changed the title fix(UI): service marketplace active list fix(service marketplace): list all active services Oct 9, 2024
@evegufy evegufy added this to the Release 24.12 milestone Oct 9, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usmanfee thank you for your contribution. Could you please update the DEPENDENCIES file? https://github.com/eclipse-tractusx/portal-frontend/actions/runs/10996801570?pr=1134

@oyo could you please review?

@Usmanfee
Copy link
Contributor Author

Usmanfee commented Oct 9, 2024

@evegufy I have updated the dependency file but the error message still persists and no any clue with the error message.
signal need to update DEPENDENCIES.

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use hard coded string values

src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
@Usmanfee Usmanfee force-pushed the fix/PM2-853-service-marketplace-active-list branch from 49a99db to 952b257 Compare October 10, 2024 08:43
@Usmanfee
Copy link
Contributor Author

@manojava-gk I have introduced enum for frequently used string for sorting type . can you have a look please ? :)

@manojava-gk
Copy link
Contributor

@Usmanfee Just to maintain consistency use PascalCase instead. See other examples in the page.

@Usmanfee
Copy link
Contributor Author

Usmanfee commented Oct 10, 2024

@manojava-gk we are also using camelcase format in e.g. PAGES and OVERLAYS enum . I am using camelcase since this is the pattern backend support.

@manojava-gk
Copy link
Contributor

@Usmanfee one more thing, constants file is a place where we host most common things in the app. I do not think this sorting type is a generic one. it is very specific to the back end api. I prefer to define this in the specific api types's file.

In future we can define this in the constants when all apis sorting types are unified.

CC: @oyo

@Usmanfee
Copy link
Contributor Author

@manojava-gk I have updated the code based on your suggestion. could you please have a look now ? Thank you :)

@manojava-gk
Copy link
Contributor

Looks fine now

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes especially it's not a good pattern to handle undefined cases with an empty string. That was in the code before and went in unnoticed but now it would be a good occasion to clean that up.

src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
src/components/pages/ServiceMarketplace/index.tsx Outdated Show resolved Hide resolved
src/features/serviceMarketplace/serviceApiSlice.ts Outdated Show resolved Hide resolved
@Usmanfee
Copy link
Contributor Author

@oyo Thanks for your feedback :) . I have resolved your comments with suggested changes.

CHANGELOG.md Outdated Show resolved Hide resolved
oyo
oyo previously approved these changes Oct 24, 2024
Copy link

sonarcloud bot commented Oct 24, 2024

@Usmanfee
Copy link
Contributor Author

@evegufy I have reverted changelog changes. @oyo could you please re-approve and merge it again ? Thank you

@Usmanfee Usmanfee requested review from oyo and evegufy October 24, 2024 13:23
@oyo oyo merged commit 231c2d1 into eclipse-tractusx:main Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

6 participants