Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service management): fix 400 issue when clicking 'Load More' button #1175

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(service management): fix 400 issue when clicking 'Load More' button #1175

merged 1 commit into from
Oct 24, 2024

Conversation

ss-nikunj
Copy link
Contributor

@ss-nikunj ss-nikunj commented Sep 30, 2024 •
edited
Loading

Description

  • In the Service Request Management section, clicking the 'Load More' button generates a 400 Bad Request error, preventing additional service requests from being loaded.

  • A 400 Bad Request error is generated when attempting to load more service requests.

Issue

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

image

CHANGELOG

  • Service Management | 400 Bad Request when Clicking 'Load More' Button #1168

@ss-nikunj ss-nikunj marked this pull request as draft September 30, 2024 05:37
shubhamv-ss
shubhamv-ss approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@shubhamv-ss shubhamv-ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ss-nikunj ss-nikunj marked this pull request as ready for review September 30, 2024 06:27
@manojava-gk
Copy link
Contributor

@ss-nikunj Did you test this scenario in App Management section?

JordanGerada3
JordanGerada3 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@JordanGerada3 JordanGerada3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested locally, LGTM!

@ss-nikunj
Copy link
Contributor Author

@ss-nikunj Did you test this scenario in App Management section?

Hi @manojava-gk, Yes I tested it in App Management section. There it is working fine.

@ss-nikunj ss-nikunj self-assigned this Sep 30, 2024
@evegufy evegufy changed the title fix: Fixed 400 issue when Clicking 'Load More' Button in Service Management fix(service management): fix 400 issue when clicking 'Load More' button Oct 9, 2024
evegufy
evegufy reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update the changelog? (frist rebase to main)

@manojava-gk could you please review?

@evegufy evegufy added this to the Release 24.12 milestone Oct 9, 2024
@ss-nikunj ss-nikunj force-pushed the fix/service-request-load-more-400-error branch from c40ee10 to 3232611 Compare October 10, 2024 06:34
@ss-nikunj
Copy link
Contributor Author

@evegufy Rebase & Changelog modified as you mentioned.

@manojava-gk Can you please review it again?

manojava-gk
manojava-gk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ss-nikunj
Copy link
Contributor Author

Hi @evegufy,

@manojava-gk approved this PR. can you please merge it?
Thank you!

@oyo

This comment was marked as duplicate.

Sign in to view
oyo
oyo requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve merge conflicts

@ss-nikunj ss-nikunj force-pushed the fix/service-request-load-more-400-error branch from 3232611 to f9ddc12 Compare October 17, 2024 05:15
@ss-nikunj ss-nikunj requested a review from oyo October 17, 2024 05:16
@ss-nikunj
Copy link
Contributor Author

@oyo Merged conflict resolved! Can you please verify and merge it?

Thank you! 🙂

evegufy
evegufy requested changes Oct 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ss-nikunj ss-nikunj force-pushed the fix/service-request-load-more-400-error branch from f9ddc12 to cb61cae Compare October 24, 2024 04:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ss-nikunj
Copy link
Contributor Author

Hi @evegufy, As you mentioned, I have removed the changelog entry and added it to the description.

@oyo oyo merged commit db441bc into eclipse-tractusx:main Oct 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamv-ss shubhamv-ss shubhamv-ss approved these changes

@JordanGerada3 JordanGerada3 JordanGerada3 approved these changes

@manojava-gk manojava-gk manojava-gk approved these changes

@evegufy evegufy evegufy approved these changes

@oyo oyo oyo approved these changes

@lavanya-bmw lavanya-bmw Awaiting requested review from lavanya-bmw

@MaximilianHauer MaximilianHauer Awaiting requested review from MaximilianHauer

Assignees

@manojava-gk manojava-gk

@ss-nikunj ss-nikunj

Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 2.3.0 (24.12)
Development

Successfully merging this pull request may close these issues.
6 participants
@ss-nikunj @manojava-gk @oyo @evegufy @JordanGerada3 @shubhamv-ss