fix(file upload): change error text of uploaded file from byte to mb #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamv-ss
reviewed
Oct 1, 2024
evegufy
requested changes
Oct 9, 2024
evegufy
changed the title
|
@oyo could you please review? |
Usmanfee
force-pushed
the
fix/upload-document-error-message
branch
from
3445f89
to
da1271c
Compare
evegufy
previously approved these changes
Oct 9, 2024
oyo
previously requested changes
Oct 16, 2024
2 tasks
Usmanfee
force-pushed
the
fix/upload-document-error-message
branch
from
f1ec80b
to
4fcad12
Compare
|
@oyo I have addressed the feedback. Can you please review now ? Thanks |
evegufy
reviewed
Oct 24, 2024
Usmanfee
force-pushed
the
fix/upload-document-error-message
branch
from
4ece1cd
to
5a353eb
Compare
evegufy
changed the base branch from
release/v2.3.0-RC2
to
release/v2.3.0-RC3
|
evegufy
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
converted file size from Bytes to Mega-Byte of uploaded document for better UX.
Changelog entry:
Why
It is hard for user to understand long digits in Bytes and easier to read in mega byte size for better understanding and usually the size of the file either comes in KB or MB.
Issue
#1184
Checklist
Please delete options that are not relevant.