-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service marketplace): fix detail images #1197
base: main
Are you sure you want to change the base?
fix(service marketplace): fix detail images #1197
Conversation
src/components/pages/ServiceMarketplace/RecommendedServices.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
added prio due to dependency with backend development. |
03ae3a1
to
e66f13f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much custom image loading logic that already has been implemented. See comments about how to use that. Also please update DEPENDENCIES.
src/components/pages/ServiceMarketplaceDetail/components/MarketplaceHeader/index.tsx
Outdated
Show resolved
Hide resolved
} | ||
loadImages() | ||
} | ||
}, [services]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better modify CardHorizontal
in the shared components to additionally allow an <Image ...>
instead of an image url then we could also use its built in loading logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b1973f9
to
51847d8
Compare
fee7636
to
3dfd6f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for build is failing.
Please also remove the changes to changelog and add a note in the PR description.
Quality Gate passedIssues Measures |
@evegufy I have reverted the change of changelog file. Regarding build failure, failure is expected since I introduced new changes in shared component which is not yet merged and released so that is why it is failing with linting. eclipse-tractusx/portal-shared-components#356 If you have any other suggestion or work around to address this blocker then please let me know! Thanks |
Hi @Usmanfee ok understood, @oyo is working on the issue why the integration takes to long, just fyi eclipse-tractusx/portal-shared-components#361 |
Description
Service marketplace and service marketplace detail page has hardcoded images are being displayed. The original image should be displayed incase of its existence otherwise default images would be displayed.
Changelog entry:
Solution
There was one parameter of
leadPictureId
was missing in response of api which actually contains the image info so with leadPictureId and now by havingleadPictureId
we are displaying actual images.Issue
#1195
Checklist