fix(OSP): added auth url field in IDP config creation #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/v2.3.0-RC1 build(2.3.0-rc1): bump version and update docs
Usmanfee
changed the title
Usmanfee
changed the title
ss-nikunj
reviewed
Oct 30, 2024
src/components/pages/OnboardingServiceProvider/OnboardingServiceProvider.tsx
Show resolved
Hide resolved
|
@Usmanfee pls fix the linting issues. and the title |
Usmanfee
changed the title
|
@saadanzari I fixed the PR title and linting but no any obvious clue about dependencies error. |
|
|
@lavanya-bmw @manojava-gk @kunalgaurav-bmw please review |
manojava-gk
reviewed
Nov 11, 2024
src/components/pages/OnboardingServiceProvider/OnboardingServiceProvider.tsx
Show resolved
Hide resolved
oyo
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new field of Auth URL for auth token address of IDP registration. Also removed the check of
.well-known/openid-configurationfor URL validation. URL just need to be in standard format with standard validation to check for valid URL and no need to check for ending substring as part of validation.Changelog entry:
Why
Previously we always sending empty string for Auth URL but now it is business requirement to allow to get Auth token URL so needed to add this new field.
Issue
#1281
Please delete options that are not relevant.