Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consentOSP): fix VAT ID/identifier in the OSP Consent Form #1325

Merged
merged 10 commits into from
Nov 14, 2024

Conversation

saadanzari
Copy link
Contributor

@saadanzari saadanzari commented Nov 13, 2024

Description

Add missing field, VAT ID/identifier in the OSP Consent Form is the Company details information.
Since the VAT id info is available in the response, it should appear under the Company details section.

Why

VAT ID is missing on the company details information.

Issue

#1323

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Changelog Entry

  • Consent OSP
    • fixed VAT ID/identifier in the OSP Consent Form, and update roles translations on language switch #1323

@saadanzari saadanzari changed the base branch from main to release/v2.3.0-RC4 November 13, 2024 10:41
@saadanzari saadanzari changed the base branch from release/v2.3.0-RC4 to main November 13, 2024 10:47
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggestions

src/components/pages/OSPConsent/CompanyDetails.tsx Outdated Show resolved Hide resolved
src/components/pages/OSPConsent/CompanyDetails.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 14, 2024

@saadanzari saadanzari requested a review from oyo November 14, 2024 09:04
@oyo oyo merged commit 546b881 into eclipse-tractusx:main Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants