update(style): updated UI #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release(1.6.0-RC1): merge release into main
release(1.6.0-RC1): merge main in dev
…-portal-frontend into update/CPLP-2920/app-service-styles
…removed unnecessary code
lavanya-bmw
requested review from
nidhigarg-bmw,
manojava-gk and
oyo
and removed request for
nidhigarg-bmw and
manojava-gk
oyo
requested changes
Jul 25, 2023
| const getAppData = (field: string) => { | ||
| if (field === 'language') return item?.languages.join(', ') | ||
| else if (field === 'useCase') return item?.useCases.join(', ') | ||
| else if (field === 'price') return item?.price |
There was a problem hiding this comment.
please always define enum type instead of hard coded strings - this improves type safety in case they are used multiple times
| </Typography> | ||
| <StaticTable | ||
| data={{ | ||
| head: ['Homepage', 'E-Mail'], |
| head: ['Homepage', 'E-Mail'], | ||
| body: [ | ||
| [ | ||
| serviceData.providerUri === 'ERROR' |
There was a problem hiding this comment.
I think somewhere we have defined an enum type for ERROR and SUCCESS - please use
| {t('content.serviceMarketplace.document.message')} | ||
| </Typography> | ||
| {item.documents && item.documents['ADDITIONAL_DETAILS'] ? ( | ||
| item.documents['ADDITIONAL_DETAILS'].map((document: DocumentData) => ( |
|
Kudos, SonarCloud Quality Gate passed!
|
oyo
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated UI for look consistency in service and app admin boards and app and service marketplace
Why
For UI consistency
Issue
Ref: CPLP-2920
Checklist
Please delete options that are not relevant.