Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certificate): error message #172

Conversation

nidhigarg-bmw
Copy link
Contributor

Description

Dynamic Error as per API response

Why

To make error more understandable

Issue

N/A

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@nidhigarg-bmw nidhigarg-bmw changed the title Fix/cplp 3001/certificate api error fix(certificate): error message Jul 27, 2023
@nidhigarg-bmw nidhigarg-bmw changed the base branch from dev to release/v1.6.0-RC4 July 27, 2023 07:19
@@ -66,9 +66,14 @@ export default function UpdateCertificate({ id }: { id: string }) {
await addCertificate(data).unwrap()
setSubmitClicked(true)
}
} catch (err) {
} catch (err: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use unknown instead of any

@nidhigarg-bmw nidhigarg-bmw requested a review from oyo July 31, 2023 08:58
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 changed the base branch from release/v1.6.0-RC4 to release/v1.6.0-RC5 July 31, 2023 09:24
@oyo oyo merged commit 666a0d6 into eclipse-tractusx:release/v1.6.0-RC5 Aug 3, 2023
5 checks passed
@oyo oyo deleted the fix/CPLP-3001/CertificateAPIError branch August 3, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants