Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates(notification): add credential approval, credential reject and subscription url msgs #175

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Jul 28, 2023

Description

create new json text for CREDENTIAL_APPROVAL, CREDENTIAL_REJECTED and SUBSCRIPTION_URL_UPDATE in notification page.
Show credentailType , appName and newUrl in both title and description

Why

CREDENTIAL_APPROVAL & CREDENTIAL_REJECTED shows raw json

Issue

NA

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@manojava-gk manojava-gk requested a review from jjeroch July 28, 2023 07:21
@manojava-gk manojava-gk changed the title updates(notification): add credential approval and reject msgs updates(notification): add credential approval, credential reject and subscription url msgs Jul 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 changed the base branch from release/v1.6.0-RC4 to release/v1.6.0-RC5 July 31, 2023 09:24
@manojava-gk manojava-gk marked this pull request as ready for review August 1, 2023 05:58
@oyo oyo merged commit 14edcde into eclipse-tractusx:release/v1.6.0-RC5 Aug 3, 2023
5 checks passed
@oyo oyo deleted the udpates/CPLP-3051-notification-text branch August 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants