feat(ssi credential): added filters #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-portal-frontend into feature/CPLP-3021/SSICredential
manojava-gk
reviewed
Aug 3, 2023
|
|
||
| const [getDocumentById] = useFetchNewDocumentByIdMutation() | ||
| const [approveCredential] = useApproveCredentialMutation() | ||
| const [declineCredential] = useDeclineCredentialMutation() | ||
|
|
||
| const setView = (e: React.MouseEvent<HTMLInputElement>) => { | ||
| const viewValue = e.currentTarget.value | ||
| if (viewValue === FilterType.OPEN) setFilterValueAPI('PENDING') |
There was a problem hiding this comment.
create an enum for PENDING, ACTIVE and INACTIVE
| } from 'features/certification/certificationApiSlice' | ||
| import { download } from 'utils/downloadUtils' | ||
| import { useFetchNewDocumentByIdMutation } from 'features/appManagement/apiSlice' | ||
| import { error, success } from 'services/NotifyService' | ||
| import { uniqueId } from 'lodash' | ||
| import { SubscriptionStatus } from 'features/apps/apiSlice' | ||
| import { setSearchInput } from 'features/appManagement/actions' | ||
| import { useDispatch } from 'react-redux' | ||
|
|
||
| export interface DummyData { |
| expr: searchExpr, | ||
| }) | ||
| } | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
any clarification for this?
oyo
requested changes
Aug 3, 2023
oyo
requested changes
Aug 3, 2023
| }, [filterStatus, searchExpr]) | ||
|
|
||
| const onValidate = (expr: string) => { | ||
| const validateExpr = /^[ A-Za-z0-9]*$/.test(expr) |
There was a problem hiding this comment.
never use a * or + in a regex because that means it can have unlimited length which is almost never what we want. Use meaningful lower and upper limits instead. For example if the text must have at least 1 but not more than 2000 characters: {1,2000}
|
Kudos, SonarCloud Quality Gate passed!
|
oyo
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added filters in SSI Credential
Why
User Friendly
Issue
n/a
Checklist
Please delete options that are not relevant.