Fix(sonar bugs): replacing promises for fetching images

[nidhigarg-bmw]

Description

Replacing promises for fetching images

Why

To avoid code smells and reuse previous code

Issue

n/a

Checklist

Please delete options that are not relevant.

• I have followed the contributing guidelines
• I have performed a self-review of my own code
• I have successfully tested my changes locally

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[oyo]

that's not the solution that we were looking for. The real solution ich much simpler and looks like this:

• modify the ImageGallery component properties from ImageType[] to { ..., src: string[], loader?: (src: string) => Promise<ArrayBuffer> } https://github.com/eclipse-tractusx/portal-shared-components/blob/main/src/components/basic/ImageGallery/index.tsx#L30
• in the same file in lines 79-97 replace the <img .../> with <Image ... src loader /> which can load the images by itself
• find all occurrences from fetchLeadPictures, get rid of the fetchLeadPictures call and give the the urls plus the fetchImageWithToken loader function
• delete the fetchLeadPictures method from CommonServices