Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates(error bar): use error bar component #229

Merged
merged 1 commit into from
Aug 25, 2023
Merged

updates(error bar): use error bar component #229

merged 1 commit into from
Aug 25, 2023

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Aug 23, 2023 •
edited
Loading

Description

show error bar component in case of failure in the following pages

  1. app overview
  2. service overview
  3. app subscription
  4. service subscription
  5. app admin board
  6. service admin board

Why

do not show No Items available message even for the api call failure

Issue

NA

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manojava-gk manojava-gk marked this pull request as ready for review August 23, 2023 07:10
@oyo oyo merged commit 8e882b0 into eclipse-tractusx:dev Aug 25, 2023
5 checks passed
@oyo oyo deleted the updates/CPLP-3053-show-error-component branch August 25, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyo oyo oyo approved these changes

@nidhigarg-bmw nidhigarg-bmw Awaiting requested review from nidhigarg-bmw

@lavanya-bmw lavanya-bmw Awaiting requested review from lavanya-bmw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manojava-gk @oyo