Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates(notification): show roles information #232

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Aug 23, 2023

Description

show app name, roles info for app_roles_added notification type

Why

content update

Issue

NA

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manojava-gk manojava-gk marked this pull request as ready for review August 23, 2023 11:52
@manojava-gk manojava-gk changed the title updates(notification): show roles updates(notification): show roles information Aug 23, 2023
Copy link
Contributor

@nidhigarg-bmw nidhigarg-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manojava-gk manojava-gk requested a review from oyo August 28, 2023 05:11
@oyo oyo merged commit ef04ad7 into eclipse-tractusx:dev Aug 31, 2023
5 checks passed
@oyo oyo deleted the updates/CPLP-1566-notification-app-role-added branch August 31, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants