Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idp): display metadata details #556

Merged

Conversation

nidhigarg-bmw
Copy link
Contributor

Description

Implementation IdP Config displaying metadata

Why

Enable Company/IT Admins to see their identity provider config inside the "Config" overlay if any configuration does already exist

Issue

#475

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

mappers: Array<IDPMapper>
oidc?: OIDCType
saml?: OIDCType
saml?: SAMLType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidhigarg-bmw can you provide me some details why this got changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjeroch In swagger this type was different so I managed to changed it accordingly
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok understood, thanks

@jjeroch jjeroch requested a review from Leon-Gr February 28, 2024 15:38
@jjeroch
Copy link
Contributor

jjeroch commented Feb 28, 2024

@Leon-Gr please review the locales files (de & en)

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@nidhigarg-bmw
Copy link
Contributor Author

@evegufy Can you please merge this PR ?

@evegufy evegufy merged commit b01acb0 into eclipse-tractusx:dev Mar 4, 2024
8 checks passed
@evegufy evegufy deleted the feat/475/DisplayIDPConfigDetails branch March 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants