Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(user menu): full height user menu #558

Merged
merged 4 commits into from
Mar 4, 2024
Merged

fix(user menu): full height user menu #558

merged 4 commits into from
Mar 4, 2024

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Feb 29, 2024 •
edited
Loading

Description

display full width menu. move menu footer to the bottom section.
no custom style for sub navigation header

Why

new change request

Issue

NA

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk
fix(hamburger): display full width menu. move menu footer to the bott…
69ebbca 
…om section. no custom style for sub navigation header
@manojava-gk manojava-gk marked this pull request as ready for review February 29, 2024 05:56
lavanya-bmw
lavanya-bmw suggested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog

src/components/shared/MobileMenu/index.tsx Outdated Show resolved Hide resolved
lavanya-bmw
lavanya-bmw approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manojava-gk
Copy link
Contributor Author

@evegufy can you merge this PR?

@evegufy
Copy link
Contributor

evegufy commented Feb 29, 2024

@manojava-gk is there no issue for this change?

@manojava-gk
Copy link
Contributor Author

@manojava-gk is there no issue for this change?

No. I have tested this in the local

@manojava-gk manojava-gk marked this pull request as draft March 1, 2024 09:12
@manojava-gk manojava-gk marked this pull request as ready for review March 4, 2024 10:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manojava-gk
Copy link
Contributor Author

@oyo @nidhigarg-bmw @lavanya-bmw Kindly review once again

nidhigarg-bmw
nidhigarg-bmw approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@nidhigarg-bmw nidhigarg-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@oyo oyo merged commit 9c6dc1c into eclipse-tractusx:dev Mar 4, 2024
8 checks passed
@oyo oyo deleted the fix/drawer-issues branch March 4, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhigarg-bmw nidhigarg-bmw nidhigarg-bmw approved these changes

@oyo oyo oyo approved these changes

@lavanya-bmw lavanya-bmw Awaiting requested review from lavanya-bmw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@manojava-gk @evegufy @oyo @nidhigarg-bmw @lavanya-bmw