Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(localdev): improve config and documentation #94

Merged
merged 7 commits into from
Sep 26, 2023
Merged

chore(localdev): improve config and documentation #94

merged 7 commits into from
Sep 26, 2023

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented Sep 25, 2023 •
edited
Loading

Description

  • remove selfsigned.yaml and move to README because file won't be available at released chart installation
  • generally improve readme
  • extend config in values file specifically to integrate with local development
  • extend helm test for TLS setup

Why

improve umbrella chart

Issue

Previous PR:
#90

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@evegufy evegufy force-pushed the localdev/improve-config_and_docu branch from 04a401f to c0d0f73 Compare September 25, 2023 14:56
@evegufy
fix(localdev): set ingress className later
14f7da7 
once the deprecated annotation 'annotations.kubernetes.io/ingress.class' is removed from the portal chart
@evegufy evegufy force-pushed the localdev/improve-config_and_docu branch from d90490a to 14f7da7 Compare September 25, 2023 15:10
@evegufy evegufy requested a review from Phil91 September 25, 2023 15:20
@evegufy evegufy merged commit 6f45363 into dev Sep 26, 2023
2 checks passed
@evegufy evegufy deleted the localdev/improve-config_and_docu branch September 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil91 Phil91 Phil91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evegufy @Phil91